Fixing POIFinder for the custom branch

[TreeMos]

I'd like to start using the eq2ui_custom.xml file as you did gm9. But unfortunately it does not seem to be a straightforward kind of deal. Unless I'm missing something obvious (quite possible).

I deleted my old eq2ui_mainhud.xml file that was in my ProfitUI dir per your red line instructions. So I tried to add the <include>eq2ui_mainhud_poifinder.xml</include> line to your copy of the custom.xml file instead. I put it after all your other <include> lines and before the </Page> tag. But on starting the game the POI Finder window could be opened and the links would work but the background would be solid black with no graphics. I also tried putting the line in your Namespace block next to _ProfitUI_Styles.xml but that didn't work any better. So next I went back to the old way by making a copy of eq2ui_mainhud.xml out of the Default dir and placing it in the ProfitUI one with the poifinder include line added in like it was before. Upon running the game everything looked good with both the links and the background being as they should.

So it doesn't seem to be an issue with my XML. Just with the way I am trying to reference it in the custom.xml file. Is there anything I'd have to change in eq2ui_mainhud_poifinder.xml or any other XML file to successfully include it using the custom.xml file?

[gm9]

I thought something like that might happen which is why I temporarily removed the <include>, but I had no time to test it or even look at your code. The include itself is not the issue, but I suspect that you somehow interact with the EQ2MAP window, which is now in a different tree. Depending on how you coded your window that may or may not make a difference. Unless you figure it out before I'll try to take a look tonight (my time) and shoot you a PM.

[Othesus]

You're essentially moving the poi finder window from the MainHUD branch of the UI to the Custom branch of the UI. To do this you'll need to make sure to change every single reference of MainHUD.POIFinder to Custom.POIFinder. You'll need to do that in the plugin_7.xml file too.

You'll probably want to change the file name from eq2ui_mainhud_poifinder.xml to eq2ui_custom_poifinder or something just to avoid confusion.

Also, unless gm9 adds the <include> to his eq2ui_custom.xml Profit users would have to disable auto-updating that file.

[gm9]

Originally Posted by Othesus

You're essentially moving the poi finder window from the MainHUD branch of the UI to the Custom branch of the UI. To do this you'll need to make sure to change every single reference of MainHUD.POIFinder to Custom.POIFinder. You'll need to do that in the plugin_7.xml file too.

Yes, but it really depends on his implementation. Since both branches are copied into the same branch (_HUD) when you show windows during runtime you can code it such that it makes no difference where you place the <include>. If however there are scripts that already apply before you load your window you would have to reference the exact branch. I just haven't looked at his code yet (maybe you did though).

Originally Posted by Othesus

Also, unless gm9 adds the <include> to his eq2ui_custom.xml Profit users would have to disable auto-updating that file.

It's just temporary, the line will go back in as soon as it works.

[TreeMos]

That does help explain it Othesus. I could fairly easily replace all MainHUD references with Custom references using search/replace tools. And gm9 has included the poifinder line with the mainhud file in the past so I imagine he'd be happy to include it with the custom file now.

I use Profit Reborn as my UI so I'm comfortable with the idea of working to make my mod more compatible with it. My biggest concern is that with such an update I'd have to re-explain to everyone who uses my mod, Profit users and those who don't, that the install instructions have changed. That there are now old files they should delete if I change the file name and different files that might have to be hand-edited. And gm9 can probably attest to how often people ignore even the most obvious instructions and then ask repeated questions about it So is there really anything gained by moving to the custom file or would it just be simpler to keep telling people to modify their mainhud.xml files? That's what I'm trying to decide now.

[Othesus]

Ok, gm9 explained why the window even shows up at all. I would still change the branch from MainHUD to Custom to avoid confusion.

I think your background problem is in line 75 here:
<Image Location="15,28" Name="ZoneMap" NormalLocation="1,2" NormalSize="436,506" PackSize="a,a" PackSizeProp="0045/0001,0045/0001" ScrollExtent="255,380" Size="255,380" Style="Map.MapStyles.z_blank"/>

should be changed to

<Image Location="15,28" Name="ZoneMap" NormalLocation="1,2" NormalSize="436,506" PackSize="a,a" PackSizeProp="0045/0001,0045/0001" ScrollExtent="255,380" Size="255,380" Style="MainHUD.Map.MapStyles.z_blank"/>

Since you've moved out of the MainHUD branch to the Custom branch the Style property doesn't connect to the right image.

[gm9]

Originally Posted by TreeMos

And gm9 can probably attest to how often people ignore even the most obvious instructions and then ask repeated questions about it

lol!

And I think the fix Othesus posted may work for both users having it included in MainHUD or in Custom. If not just copy the style over to your window. Then you won't have to bother too much about people reading instructions, since it will work both ways.

[TreeMos]

Well with the poifinder inlcude back in the eq2ui_custom.ml file I tried Othesus' idea of adding MainHUD. to that one line, but it didn't change anything. Again the black background. I also tried putting it in front of any line beginning with RStyle=" that pointed to a Map.WindowFrame.Something but that didn't help either.

Could it possibly be a problem with RStyleDefault="WindowElements.WindowFrame.data. on lines 73 and 74? Do I need to add a MainHUD prefix there as well?

[gm9]

Ok, see attached, I've only included the changed files. It works with both an <include> in mainhud or custom, so your users will never know.

I had to do some fancy coding in the plugin for that because I discovered a bug with the custom branch. You can /show_window MainHUD.POIFinder even if you <include> it in custom, i.e. when it technically is not in MainHUD. However, something apparently goes wrong then, because it does not correctly read the styles in that case. On the other hand, you cannot /show_window Custom.POIFinder if you include in the mainhud branch. But that just as background information.

PS: I did not understand why you renamed the close button in the poifinder.xml just to add a OnPress="hide_window ..." to it. Note that I renamed the button back to close and removed the OnPress. If there is a reason why you did as you did you will need to retrieve the correct window location from the variable I store in the plugin.

[TreeMos]

Thanks gm9 for your help I'll give it a look and a try, and if all goes well I'll issue an update with your changes.

As for why I did certain things... well to be honest I didn't do most of them. I just took what Mother9987 did and auto-generated the repetitive parts of it. A guy named jnils also helped me revamp a lot of the XML back in version 1.10 so the Close Button bit might have gotten added then. But I'll be the first to admit that for a lot of what "My" mod does, I have no idea why it works the way it does

[TreeMos]

Good news: With your changes Window appears and closes as should and has the proper background instead of the Black one!

Bad news: All the POI link text is missing

[gm9]

Oh really? Works for me. Are you sure you tested in a zone that has POI links (I suppose so)?

You could also try to force the links visible by amending the ShowFinder button in the plugin_7.xml as follows:

<Button Name="ShowFinder" OnPress="COND=(Parent.Parent.Parent.Parent.Parent.MainHUD.POIFinder.Name==POIFinder)
CorrectLocation=COND ? MainHUD.POIFinder : Custom.POIFinder 
show_window CorrectLocation
Parent.OnChangeMapPanel.Activated=true" ScrollExtent="15,15" Size="15,15" Style="/ButtonStyles.options_button" Tooltip="Show POI Finder Window"/>

Should not be necessary though, EQ2MAP should handle that.

[dragowulf]

Please update this.

[gm9]

What do you think we are doing here?

[kathygnome]

Quick note. I installed the fix as well and I'm getting the same behavior. Window appears with correct background, but there is no text.

[gm9]

ok, can both of you let me know the following:

• did you <include> POIFinder in eq2ui_mainhud.xml or in eq2ui_custom.xml or in both (don't do the latter...)?
• where you using TreeMos' latest download or the updater someone posted?
• does the text appear after you zone or after you switch tabs in the eq2map window or does it remain hidden?
• is the text hidden in any zone or just a specific zone? Remember, it won't work in new zones like RoK yet.

With that information I'll try to reproduce it then.

[TreeMos]

Last night I just wanted to play Kunark so I went back to using the mainhud file temporarily which still works fine. And I was in the new Kunark zones with freshly downloaded POIs and generated POI Finder files so that isn't the issue. I'll experiment some more this afternoon if I can with the custom.xml method. But if I still can't get it to work I'll just post an update using the old method until I can get the new way working.

[kathygnome]

I'm at work, but I added the include to the custom file.

The mainhud one is removed in profit isn't it?

(Or can I put it back temporarily?)

[gm9]

yes and yes (although not the old ProfitUI one, take the one from \Default)

[gm9]

Ok guys, I tried my best to reproduce this. On a clean installation of ProfitUI from the updater plus a clean installation of EQ2MAP + the latest POIfinder download + the files I attached above, and having added the necessary <include> to eq2ui_custom.xml, I walked through Qeynos and had no issues getting the links to show. If it's no installation mistake on your part I simply don't know what's wrong, sorry.

[TreeMos]

Sorry to make you sweat for nothing there I tried renaming the old Profit directory and then reinstalling Profit, EQ2Map, and my POI files. Then added in your 2 changed files gm9 and edditng the custom.xml file. POI Finder now works as it should and my InfoCenter has info in it again too Both probably just needed the fresh Profit install.

I'll try to have a new POI Finder release up in the next hour or so. I won't bundle the custom file. I'll just explain how it should be edited in my Install instructions. I assume gm9 will change the Profit files to include the extra line shortly thereafter anyway.

[kathygnome]

Thank you both so much for your work!!

[gm9]

Originally Posted by TreeMos

I'll try to have a new POI Finder release up in the next hour or so. I won't bundle the custom file. I'll just explain how it should be edited in my Install instructions. I assume gm9 will change the Profit files to include the extra line shortly thereafter anyway.

Just to make sure: You do realize that I put in some fancy coding just so you did not have to change installation instructions, don't you? Meaning those files work in both MainHUD and Custom. Even so I think it is good when gradually all mods migrate to Custom, just wanted to make sure you had understood what was changed (the code snippet posted above is actually where it determines whether the user installed in MainHUD oder Custom).

EDIT: Of course the above would only have applied if you had not renamed the file... Since people will now have to edit their files anyway better take out that coding again, it's just wasted clock cycles now.

[TreeMos]

Originally Posted by gm9

EDIT: Of course the above would only have applied if you had not renamed the file... Since people will now have to edit their files anyway better take out that coding again, it's just wasted clock cycles now.

Heh, sorry to have wasted your time for nothing. I could change the file name back again but I'd rather not update just for that. Mainly I was thinking that the new install instructions would be complicated enough without confusing people more my telling that they could do multiple things. I prefered to just tell them one way, even if it would initially be more complicated. I think there will be enough clock cycles to go around. Besides I had been looking for a good example on how to do in-XML scripting for quite some time and now finally I have one where I understand exactly what it is doing

[gm9]

Since I was playing with EQ2MAP anyway, attached is a version of POIFinder with the extra code removed, placement and graphic of the icon changed, and where the links update after zoning once you mouse your mouse over the window.

Oh and for a scripting tutorial, _ProfitUI_CuresCode.xml will probably teach you most things you will ever want to know but should be easy enough to understand after a moment.