Quote:
|
Originally Posted by Zonx
FWIW, I agree its better to avoid altering higher level files... If you're only using 1 window that makes use of those styles, or a handfull of windows in the same UI branch with a relatively simple style set.
The overhead of including a large style set into several windows might cause a noticable performance hit. Someone with better diag tools than I would have to test this. Not sure if EQ2 would end up loading the same resources multiple times due to different window nestings. If Death chimes in on this one, I'd trust him. He's probably more of a programmer than me 
Also haven't tested if its even possible to span UI branches with style refs. My latest Journal mod includes the HTML window, which isn't inside the Journal branch.
As far as not wanting to customize eq2ui.xml goes... in the 3 months I've been including eq2ui.xml, I think its been changed by SOE twice, to add SplitterStyles and IME. Its been the least of my troubles  |
Zonx,
I wasn't saying that the way you are doing it with the eq2ui.xml is wrong or anything like that, I was just offering an alternative to those that want to include special styles in their mod without having to use the Includes in their eq2ui.xml file. And by all means if multipe windows in our custom mods folder use these custom styles I by all means agree with using the custom styles file and calling it out in the eq2ui.xml file.
The only file in my guild mates Custom UI folder that uses custom styles is the modified version of your Quest Journal window (Pre-Html 3.3 version). Since this file is not a always open window, I would hope that the additional overhead by including the style within the file would not be that great. And yes adding the style to the journal.xml file increased the size from some 25 KB to around 109 KB. I have toyed with the idea of removing the unused style call outs in the Styles Section of the Journal window, but have yet to try that to see if I can make the file any smaller. And BTW I love your quest journal mod.